• Fiona@discuss.tchncs.de
      link
      fedilink
      arrow-up
      5
      ·
      edit-2
      4 hours ago

      And that isn’t even the worst thing about it…

      The implementation looks like this:

      function isEven(i) {
        return !isOdd(i);
      };
      

      And yes, is-odd is a dependency that in turn depends on is-number

    • Micromot
      link
      fedilink
      English
      arrow-up
      8
      arrow-down
      1
      ·
      edit-2
      7 hours ago

      Can’t you just

      If (number % 2 == 0){return true}

      • drake@lemmy.sdf.org
        link
        fedilink
        arrow-up
        2
        ·
        4 hours ago

        but what if number isn’t an integer, or even a number at all? This code, and the improved code shared by the other user, could cause major problems under those conditions. Really, what you would want, is to validate that number is actually an integer before performing the modulo, and if it isn’t, you want to throw an exception, because something has gone wrong.

        That’s exactly what that NPM module does. And this is why it’s not a bad thing to use packages/modules for even very simple tasks, because they help to prevent us from making silly mistakes.

        • Micromot
          link
          fedilink
          English
          arrow-up
          1
          ·
          1 hour ago

          That would already cause an exception when calling the function because it has int number in the parameters