JPDev@programming.dev to Programmer Humor@programming.dev · 7 months agoReview Pleaseprogramming.devimagemessage-square15fedilinkarrow-up14arrow-down10
arrow-up14arrow-down1imageReview Pleaseprogramming.devJPDev@programming.dev to Programmer Humor@programming.dev · 7 months agomessage-square15fedilink
minus-squareripcord@lemmy.worldlinkfedilinkarrow-up0·7 months agoWas there much value in the refactoring, like tech debt addressed?
minus-squareonlinepersona@programming.devlinkfedilinkEnglisharrow-up1·7 months agoDoesn’t matter. One concern per PR. Refactoring and tech debt are separate concerns. CC BY-NC-SA 4.0
minus-squareJesus_666@feddit.delinkfedilinkarrow-up0·7 months agoOr, if the team does allow refactoring as part of an unrelated PR, have clean commits that allow me to review what you did in logical steps. If that’s not how you worked on the change than you either rewrite the history to make it look like you did or you’ll have to start over.
Was there much value in the refactoring, like tech debt addressed?
Doesn’t matter. One concern per PR. Refactoring and tech debt are separate concerns.
CC BY-NC-SA 4.0
Or, if the team does allow refactoring as part of an unrelated PR, have clean commits that allow me to review what you did in logical steps.
If that’s not how you worked on the change than you either rewrite the history to make it look like you did or you’ll have to start over.