• tal@lemmy.today
    link
    fedilink
    English
    arrow-up
    44
    ·
    6 months ago

    I don’t really understand the attack vector the ISP is using, unless it’s exploiting some kind of flaw in higher-level software than BitTorrent itself.

    A torrent should be identified uniquely by a hash in a magnet URL.

    When a BitTorrent user obtains a hash, as long as it’s from an https webpage, the ISP shouldn’t be able to spoof the hash. You’d have to either get your own key added to a browser’s keystore or have access to one of the trusted CA’s keys for that.

    Once you have the hash, you should be able to find and validate the Merkle hash tree from the DHT. Unless you’ve broken SHA and can generate collisions – which an ISP isn’t going to – you shouldn’t be able to feed a user a bogus hash tree from the DHT.

    Once you have the hash tree, you shouldn’t be able to feed a user any complete chunks that are bogus unless you’ve broken the hash function in BitTorrent’s tree (which I think is also SHA). You can feed them up to one byte short of a chunk, try and sandbag a download, but once they get all the data, they should be able to reject a chunk that doesn’t hash to the expected value in the tree.

    I don’t see how you can reasonably attack the BitTorrent protocol, ISP or no, to try and inject malware. Maybe some higher level protocol or software package.

      • tal@lemmy.today
        link
        fedilink
        English
        arrow-up
        6
        ·
        edit-2
        6 months ago

        If ISP routers are anything like the west that means they control the DNS servers and the ones on router cannot be changed, and likely it blocks 1.1.1.1 and 8.8.8.8 and so on, as Virgin Media does (along with blocking secure DNS) in the UK for example, which definitely opens up a massive attack vector for an ISP to spin up its own website with a verified cert and malware and have the DNS resolve to that when users try to access it to either download the software needed to access this Grid System or if it’s a web portal - the portal itself.

        Browser page integrity – if you’re using https – doesn’t rely on DNS responses.

        If I go to “foobar.com”, there has to be a valid cert for “foobar.com”. My ISP can’t get a valid cert for foobar.com unless it has a way to insert its own CA into my browser’s list of trusted CAs (which is what some business IT departments do so that they cans snoop on traffic, but an ISP probably won’t be able to do, since they don’t have access to your computer) or has access to a trusted CA’s key, as per above.

        They can make your browser go to the wrong IP address, but they can’t make that IP address present information over https that your browser believes to belong to a valid site.

          • tal@lemmy.today
            link
            fedilink
            English
            arrow-up
            2
            ·
            edit-2
            6 months ago

            I don’t see why they wouldn’t, or couldn’t do this

            There are only 52 organizations that Firefox trusts to act as CAs. An ISP isn’t normally going to be on there.

            https://wiki.mozilla.org/CA/Included_Certificates

            https://ccadb.my.salesforce-sites.com/mozilla/CACertificatesInFirefoxReport

            If whatever cert is presented by a remote website doesn’t have a certificate signed by one of those 52 organizations, your browser is going to throw up a warning page instead of showing content. KT Corporation, the ISP in question, isn’t one of those organizations.

            They can go create a CA if they want, but it doesn’t do them any good unless it’s trusted by Firefox (or whatever browser people use, but I’m using Firefox, and I expect that basically the same CAs will be trusted by any browser, so…)

              • Zeoic@lemmy.world
                link
                fedilink
                English
                arrow-up
                1
                ·
                6 months ago

                Well for one, ISPs are not the government, and two, if any CA was caught doing this, browsers like firefox would drop them. Hopefully google would too, but who knows. Thats an aweful lot of risk on their part.

                  • Zeoic@lemmy.world
                    link
                    fedilink
                    English
                    arrow-up
                    1
                    arrow-down
                    1
                    ·
                    6 months ago

                    Exactly, and with ISPs not being the government, they can not force CAs to do anything. And yes, if a CA complys with an insane law that allows anyone to skirt around security and privacy (their ENTIRE purpose), they will lose the faith of the public, and people will drop them. Whether it was legal or not doesn’t matter much for public sentiment.

    • frankgrimeszz@lemmy.world
      link
      fedilink
      English
      arrow-up
      10
      ·
      6 months ago

      Some software check for updates without requiring the packages to be signed. The ISP could do a HTTP redirect to a fake torrent client update. The program says “Update available”. It downloads a malicious version.

      Other ISPs have been caught injecting adverts into their traffic. So there’s ways.

        • frankgrimeszz@lemmy.world
          link
          fedilink
          English
          arrow-up
          1
          ·
          6 months ago

          HTTPS would prevent advert injection, assuming you didn’t accept a bad certificate at any point. But if they control your router and infrastructure, they can still redirect you to other pages however they want.

    • tal@lemmy.today
      link
      fedilink
      English
      arrow-up
      8
      ·
      edit-2
      6 months ago

      I’d also add, on an unrelated note, that if the concern is bandwidth usage, which is what the article says, I don’t see why the ISP doesn’t just throttle users, based entirely on bandwidth usage. Like, sure, there are BitTorrent users that use colossal amounts of bandwidth, will cause problems for pricing based on overselling bandwidth, which is the norm for consumer broadband.

      But you don’t need to do some kind of expensive, risky, fragile, and probably liability-issue-inducing attack on BitTorrent if your concern is bandwidth usage. Just start throttling down bandwidth as usage rises, regardless of protocol. Nobody ever gets cut off, but if they’re using way above their share of bandwidth, they’re gonna have a slower connection. Hell, go offer to sell them a higher-bandwidth package. You don’t lose money, nobody is installing malware, you don’t have the problem come right back as soon as some new bandwidth-munching program shows up (YouTube?), etc.

      • AwesomeLowlander@lemmy.dbzer0.com
        link
        fedilink
        English
        arrow-up
        3
        ·
        6 months ago

        if they’re using way above their share of bandwidth

        Based on the numbers reported in the article, that’s a significant chunk of their customers. The ISP was probably reluctant to upgrade their infra like they should have.

    • Lojcs@lemm.ee
      link
      fedilink
      English
      arrow-up
      4
      ·
      6 months ago

      Do torrent clients actually check the hash? I’ve had borked downloads that qbittorrent showed as complete but had to be redownloaded upon a recheck before.