• OhNoMoreLemmy@lemmy.ml
    link
    fedilink
    arrow-up
    0
    ·
    10 months ago

    That’s really not enough.

    Review stops people from polluting your repo with bad code and lets you give feedback.

    It doesn’t stop people from wasting time writing unfixably bad code that just needs to be thrown out.

    Now of course what you can do is give people very small coding tasks and regularly review them before getting it into a shape where it can go in the main repo. But this is just micromanagement via git.

    • redprog@feddit.de
      link
      fedilink
      arrow-up
      0
      ·
      10 months ago

      If that person made it through the probation period under your supervision, that’s still your fault. And if that person was there from the beginning, a senior in your team could still support them by teaching them good practices, showing them better options, etc. Or, as a last resort you could always assign them tasks that are more within their capabilities.

      Micromanagement will never lead to people improving - quite the opposite in fact, they’ll start to care less because there’s always someone who prevents them doing mistakes.