• Username@feddit.de
    link
    fedilink
    arrow-up
    0
    ·
    edit-2
    11 months ago

    I wanted to ask why it’s bad, what did you change?

    Btw. the example function get_default is badly chosen, because unwrap_or_default exists.

    • xor@lemmy.blahaj.zone
      link
      fedilink
      English
      arrow-up
      0
      ·
      11 months ago

      The original example was doing the unwrap_within an iterator doing some string parsing, so there was a lot of unrelated boilerplate around the actual unwrapping that made it really unclear, as well as usual unwrap_or_else to produce a constant value

      Ehhh, I was more using get_default as a placeholder for some function, as opposed to representing Default::default for the inner type specifically. I think it should be alright since only people familiar with rust would know about the default trait anyway. I did consider adding an unwrap_or_default example, but thought it was getting a bit off topic at that point.